Merge pull request #1 from RyanHx/crash-fixes

Crash & filewatch fixes

src/fileWatch.js

@@ -11,13 +11,12 @@ function fileFilter(file) {
     return false;
 }
 
-const watch = new CheapWatch({
+export async function setupWatch(signaller) {
+    const watch = new CheapWatch({
         dir: config.get("scriptsFolder"),
         filter: fileFilter,
         watch: !config.get("dry")
-});
-
-export async function setupWatch(signaller) {
+    });
 
     if (!config.get("quiet")) console.log("Watching folder", resolve(config.get("scriptsFolder")))
 
@@ -34,7 +33,3 @@ export async function setupWatch(signaller) {
 
     return watch;
 }
-
-export function watchedFiles() {
-    return watch.paths;
-}

src/index.js

@@ -13,7 +13,7 @@ export async function start() {
     const socket = setupSocket(signal);
 
     // Add a handler for received messages.
-    signal.on(EventType.MessageReceived, msg => messageHandler(signal, msg));
+    signal.on(EventType.MessageReceived, msg => messageHandler(signal, msg, watch.paths));
 
     // Add a handler for when a connection to a game is made.
     signal.on(EventType.ConnectionMade, () => {

src/networking/messageHandler.js

@@ -1,11 +1,10 @@
 import { messageTracker } from "./messageTracker.js";
 import { writeFile } from "fs";
 import { config } from "../config.js";
-import { watchedFiles } from "../fileWatch.js";
 import { EventType } from "../eventTypes.js";
 import { fileChangeEventToMsg } from "./messageGenerators.js";
 
-export function messageHandler(signaller, msg) {
+export function messageHandler(signaller, msg, paths) {
     let incoming;
 
     try { incoming = JSON.parse(msg.toString()); }
@@ -15,7 +14,7 @@ export function messageHandler(signaller, msg) {
 
     if (incoming.result) {
         const request = messageTracker.get(incoming.id);
-        if (request.method &&
+        if (request?.method &&
             request.method == "getDefinitionFile"
             && incoming.result) {
             writeFile(config.get("definitionFile").location, incoming.result, (err) => {
@@ -23,12 +22,12 @@ export function messageHandler(signaller, msg) {
             });
         }
 
-        if (request.method &&
+        if (request?.method &&
             request.method == "getFileNames"
             && incoming.result) {
             const gameFiles = incoming.result.map(file => removeLeadingSlash(file));
 
-            watchedFiles().forEach((stats, fileName) => {
+            paths.forEach((stats, fileName) => {
                 if (!stats.isDirectory() && !gameFiles.includes(fileName))
                     signaller.emit(EventType.MessageSend, fileChangeEventToMsg({ path: fileName }));
             })

src/networking/messageTracker.js

@@ -6,7 +6,7 @@ class MessageTracker {
         this.data.set(msg.id, msg);
 
         if (this.data.size > this.#maxLength) {
-            const [firstKey] = map.keys();
+            const [firstKey] = this.data.keys();
             this.data.delete(firstKey);
         }
     }