From 920d2b33074534fb4b2f2387db1d69a983e1d61b Mon Sep 17 00:00:00 2001
From: baku <baku@mozilla.com>
Date: Wed, 1 Feb 2017 11:25:08 +0100
Subject: [PATCH] Introducing this._isKnownContainer()

---
 index.js | 53 +++++++++++++++++++++++------------------------------
 1 file changed, 23 insertions(+), 30 deletions(-)

diff --git a/index.js b/index.js
index 1f9af82..9711df0 100644
--- a/index.js
+++ b/index.js
@@ -224,23 +224,23 @@ const ContainerService = {
     });
   },
 
+  _isKnownContainer(userContextId) {
+    return userContextId in this._identitiesState;
+  },
+
   // Tabs management
 
   hideTabs(args) {
-    return new Promise((resolve, reject) => {
-      if (!("userContextId" in args)) {
-        reject("hideTabs must be called with userContextId argument.");
-        return;
-      }
+    if (!("userContextId" in args)) {
+      return Promise.reject("hideTabs must be called with userContextId argument.");
+    }
 
-      this._remapTabsIfMissing(args.userContextId);
-
-      // We should check if this userContextId exists.
-      if (!(args.userContextId in this._identitiesState)) {
-        resolve(null);
-        return;
-      }
+    this._remapTabsIfMissing(args.userContextId);
+    if (!this._isKnownContainer(args.userContextId)) {
+      return Promise.resolve(null);
+    }
 
+    return new Promise(resolve => {
       this._containerTabIterator(args.userContextId, tab => {
         const object = this._createTabObject(tab);
 
@@ -268,11 +268,8 @@ const ContainerService = {
     }
 
     this._remapTabsIfMissing(args.userContextId);
-
-    // We should check if this userContextId exists.
-    if (!(args.userContextId in this._identitiesState)) {
-      resolve(null);
-      return;
+    if (!this._isKnownContainer(args.userContextId)) {
+      return Promise.resolve(null);
     }
 
     const promises = [];
@@ -337,20 +334,16 @@ const ContainerService = {
   },
 
   getTabs(args) {
+    if (!("userContextId" in args)) {
+      return Promise.reject("getTabs must be called with userContextId argument.");
+    }
+
+    this._remapTabsIfMissing(args.userContextId);
+    if (!this._isKnownContainer(args.userContextId)) {
+      return Promise.resolve([]);
+    }
+
     return new Promise((resolve, reject) => {
-      if (!("userContextId" in args)) {
-        reject("getTabs must be called with userContextId argument.");
-        return;
-      }
-
-      this._remapTabsIfMissing(args.userContextId);
-
-      // We should check if this userContextId exists.
-      if (!(args.userContextId in this._identitiesState)) {
-        resolve([]);
-        return;
-      }
-
       const list = [];
       this._containerTabIterator(args.userContextId, tab => {
         list.push(this._createTabObject(tab));