From 0ef50dd2f0092a50fbc6ec5f893403be28778193 Mon Sep 17 00:00:00 2001
From: eladyn <eladyn@protonmail.com>
Date: Tue, 19 Apr 2022 16:04:50 +0200
Subject: [PATCH] enable proxyDNS only for supported proxies (SOCKS4/5)

---
 src/js/background/assignManager.js | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/js/background/assignManager.js b/src/js/background/assignManager.js
index d98c462..b4a8162 100644
--- a/src/js/background/assignManager.js
+++ b/src/js/background/assignManager.js
@@ -197,12 +197,17 @@ window.assignManager = {
       return {};
     }
 
+    // proxyDNS only works for SOCKS proxies
+    if (result.proxy.type === "socks" || result.proxy.type === "socks4" ) {
+      result.proxy.proxyDNS = true;
+    }
+
     if (!result.proxy.mozProxyEnabled) {
-      return { ...result.proxy, proxyDNS: true };
+      return result.proxy;
     }
 
     // Let's add the isolation key.
-    return [{ ...result.proxy, connectionIsolationKey: "" + MozillaVPN_Background.isolationKey, proxyDNS: true }];
+    return [{ ...result.proxy, connectionIsolationKey: "" + MozillaVPN_Background.isolationKey }];
   },
 
   // Before a request is handled by the browser we decide if we should