Reject() calls when arguments are wrong (#77)

This commit is contained in:
Andrea Marchesini 2017-01-12 13:05:08 +01:00 committed by Jonathan Kingston
parent 8b3b211d84
commit 1675ebdf90

View file

@ -164,10 +164,14 @@ let ContainerService = {
// Tabs management // Tabs management
hideTabs(args) { hideTabs(args) {
return new Promise(resolve => { return new Promise((resolve, reject) => {
if (!("userContextId" in args)) {
reject("hideTabs must be called with userContextId argument.");
return;
}
for (const tab of tabs) { for (const tab of tabs) {
const userContextId = this._getUserContextIdFromTab(tab); if (args.userContextId !== this._getUserContextIdFromTab(tab)) {
if ("userContextId" in args && args.userContextId !== userContextId) {
continue; continue;
} }
@ -180,6 +184,11 @@ let ContainerService = {
}, },
showTabs(args) { showTabs(args) {
if (!("userContextId" in args)) {
Promise.reject("showTabs must be called with userContextId argument.");
return;
}
let promises = []; let promises = [];
for (let url of this._identitiesState[args.userContextId].hiddenTabUrls) { for (let url of this._identitiesState[args.userContextId].hiddenTabUrls) {
@ -367,6 +376,11 @@ let ContainerService = {
}, },
getIdentity(args) { getIdentity(args) {
if (!("userContextId" in args)) {
Promise.reject("getIdentity must be called with userContextId argument.");
return;
}
let identity = ContextualIdentityService.getIdentityFromId(args.userContextId); let identity = ContextualIdentityService.getIdentityFromId(args.userContextId);
return Promise.resolve(identity ? this._convert(identity) : null); return Promise.resolve(identity ? this._convert(identity) : null);
}, },