rowan/multi-account-containers
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Adding tooltips. Fixes #615. Fixes #609. Fixes #112

Browse source
This commit is contained in:
Jonathan Kingston 2017-06-22 12:09:32 +01:00
parent 6292d9b25d
commit 214a83deda
4 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.gitignore vendored
View file

@ -1,4 +1,5 @@
.DS_Store .DS_Store
package-lock.json
node_modules node_modules
README.html README.html
*.xpi *.xpi

1
index.js
View file

@ -1213,6 +1213,7 @@ ContainerWindow.prototype = {
const menuItemElement = this._window.document.createElementNS(XUL_NS, "menuitem"); const menuItemElement = this._window.document.createElementNS(XUL_NS, "menuitem");
this._panelElement.appendChild(menuItemElement); this._panelElement.appendChild(menuItemElement);
menuItemElement.className = "menuitem-iconic"; menuItemElement.className = "menuitem-iconic";
menuItemElement.setAttribute("tooltiptext", identity.name);
menuItemElement.setAttribute("label", identity.name); menuItemElement.setAttribute("label", identity.name);
menuItemElement.setAttribute("data-usercontextid", identity.userContextId); menuItemElement.setAttribute("data-usercontextid", identity.userContextId);
menuItemElement.setAttribute("data-identity-icon", identity.icon); menuItemElement.setAttribute("data-identity-icon", identity.icon);

10
webextension/js/popup.js
View file

@ -520,7 +520,9 @@ Logic.registerPanel(P_CONTAINERS_LIST, {
context.classList.add("userContext-wrapper", "open-newtab", "clickable"); context.classList.add("userContext-wrapper", "open-newtab", "clickable");
manage.classList.add("show-tabs", "pop-button"); manage.classList.add("show-tabs", "pop-button");
manage.title = escaped`View ${identity.name} container`;
context.setAttribute("tabindex", "0"); context.setAttribute("tabindex", "0");
context.title = escaped`Create ${identity.name} tab`;
context.innerHTML = escaped` context.innerHTML = escaped`
<div class="userContext-icon-wrapper open-newtab"> <div class="userContext-icon-wrapper open-newtab">
<div class="usercontext-icon" <div class="usercontext-icon"
@ -683,7 +685,7 @@ Logic.registerPanel(P_CONTAINER_INFO, {
tr.classList.add("container-info-tab-row"); tr.classList.add("container-info-tab-row");
tr.innerHTML = escaped` tr.innerHTML = escaped`
<td></td> <td></td>
<td class="container-info-tab-title truncate-text">${tab.title}</td>`; <td class="container-info-tab-title truncate-text" title="${tab.url}" >${tab.title}</td>`;
tr.querySelector("td").appendChild(Utils.createFavIconElement(tab.favicon)); tr.querySelector("td").appendChild(Utils.createFavIconElement(tab.favicon));
// On click, we activate this tab. But only if this tab is active. // On click, we activate this tab. But only if this tab is active.
@ -741,15 +743,15 @@ Logic.registerPanel(P_CONTAINERS_EDIT, {
src="/img/container-edit.svg" src="/img/container-edit.svg"
class="pop-button-image" /> class="pop-button-image" />
</td> </td>
<td class="remove-container pop-button delete-container-icon" > <td class="remove-container pop-button delete-container-icon">
<img <img
class="pop-button-image" class="pop-button-image"
src="/img/container-delete.svg" src="/img/container-delete.svg"
/> />
</td>`; </td>`;
tr.querySelector(".container-name").textContent = identity.name; tr.querySelector(".container-name").textContent = identity.name;
tr.querySelector(".edit-container .pop-button-image").setAttribute("title", `Edit ${identity.name} container`); tr.querySelector(".edit-container").setAttribute("title", `Edit ${identity.name} container`);
tr.querySelector(".remove-container .pop-button-image").setAttribute("title", `Edit ${identity.name} container`); tr.querySelector(".remove-container").setAttribute("title", `Delete ${identity.name} container`);
Logic.addEnterHandler(tr, e => { Logic.addEnterHandler(tr, e => {

6
webextension/popup.html
View file

@ -73,7 +73,7 @@
</label> </label>
</div> </div>
<div class="container-panel-controls"> <div class="container-panel-controls">
<a href="#" class="action-link" id="sort-containers-link">Sort Tabs</a> <a href="#" class="action-link" id="sort-containers-link" title="Sort tabs into container order">Sort Tabs</a>
</div> </div>
<div class="scrollable panel-content" tabindex="-1"> <div class="scrollable panel-content" tabindex="-1">
<table class="identities-list"> <table class="identities-list">
@ -84,8 +84,8 @@
<div class="edit-containers-text panel-footer-secondary"> <div class="edit-containers-text panel-footer-secondary">
<a href="#" tabindex="0" id="edit-containers-link">Edit Containers</a> <a href="#" tabindex="0" id="edit-containers-link">Edit Containers</a>
</div> </div>
<a href="#" tabindex="0" class="add-container-link pop-button" id="container-add-link"> <a href="#" tabindex="0" class="add-container-link pop-button" id="container-add-link" title="Create new container">
<img class="pop-button-image-small icon" alt="Create new container icon" title="Create new container" src="/img/container-add.svg" /> <img class="pop-button-image-small icon" alt="Create new container icon" src="/img/container-add.svg" />
</a> </a>
</div> </div>
</div> </div>