From 4db04e1df5bef620887922d6805d498c881e3bc3 Mon Sep 17 00:00:00 2001 From: groovecoder Date: Mon, 27 Feb 2017 15:37:04 -0600 Subject: [PATCH] fix #272: add event telemetry for incompat addons --- docs/metrics.md | 9 +++++++++ index.js | 8 +++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/docs/metrics.md b/docs/metrics.md index 50e9728..3a0bb86 100644 --- a/docs/metrics.md +++ b/docs/metrics.md @@ -169,6 +169,15 @@ of a `testpilottest` telemetry ping for each scenario. } ``` +* When a user encounters the disabled "move" feature because of incompatible add-ons + +```js + { + "uuid": , + "event": "incompatible-addons-detected" + } +``` + ### A Redshift schema for the payload: ```lua diff --git a/index.js b/index.js index 878236b..c9784cd 100644 --- a/index.js +++ b/index.js @@ -500,7 +500,13 @@ const ContainerService = { return new Promise(resolve => { AddonManager.getAddonsByIDs(INCOMPATIBLE_ADDON_IDS, (addons) => { addons = addons.filter((a) => a && a.isActive); - resolve(addons.length !== 0); + const incompatibleAddons = addons.length !== 0; + if (incompatibleAddons) { + this.sendTelemetryPayload({ + "event": "incompatible-addons-detected" + }); + } + resolve(incompatibleAddons); }); }); },