From 5b58168999af68871ad267827a5e3fef7f1e7997 Mon Sep 17 00:00:00 2001 From: shivangikakkar Date: Tue, 1 Jan 2019 03:12:10 +0900 Subject: [PATCH] Refactored the logic to form warning message --- src/js/popup.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/js/popup.js b/src/js/popup.js index e0db6fe..9005ff3 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -1082,15 +1082,12 @@ Logic.registerPanel(P_CONTAINER_DELETE, { document.getElementById("delete-container-name").textContent = identity.name; const totalNumberOfTabs = identity.numberOfHiddenTabs + identity.numberOfOpenTabs; + let warningMessage = ""; if (totalNumberOfTabs > 0) { - let warningMessage = `If you remove this container now, ${totalNumberOfTabs} `; - warningMessage += totalNumberOfTabs > 1 - ? "container tabs will be closed." - : "container tab will be closed."; - document.getElementById("delete-container-tab-warning").textContent = warningMessage; - } else { - document.getElementById("delete-container-tab-warning").textContent = ""; + const grammaticalNumTabs = totalNumberOfTabs > 1 ? "tabs" : "tab"; + warningMessage = `If you remove this container now, ${totalNumberOfTabs} container ${grammaticalNumTabs} will be closed.`; } + document.getElementById("delete-container-tab-warning").textContent = warningMessage; const icon = document.getElementById("delete-container-icon"); icon.setAttribute("data-identity-icon", identity.icon);