From 6115b1bcb9f2e7835bd062f14b816c676b9a78f2 Mon Sep 17 00:00:00 2001
From: luke crouch <luke.crouch@gmail.com>
Date: Tue, 7 Feb 2017 11:15:54 -0600
Subject: [PATCH] fix #142: disable arrow if container has no tabs (#153)

---
 webextension/css/popup.css | 6 ++++++
 webextension/js/popup.js   | 6 ++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/webextension/css/popup.css b/webextension/css/popup.css
index 13e2ad3..6f3bb06 100644
--- a/webextension/css/popup.css
+++ b/webextension/css/popup.css
@@ -274,6 +274,12 @@ table.unstriped tbody tr {
   --identity-icon: url("/img/usercontext.svg#circle");
 }
 
+.no-tabs-img {
+  block-size: 12px;
+  filter: opacity(30%);
+  inline-size: 12px;
+}
+
 .show-tabs-img {
   block-size: 12px;
   inline-size: 12px;
diff --git a/webextension/js/popup.js b/webextension/js/popup.js
index a11d54d..5d678eb 100644
--- a/webextension/js/popup.js
+++ b/webextension/js/popup.js
@@ -222,6 +222,8 @@ Logic.registerPanel(P_CONTAINERS_LIST, {
     const fragment = document.createDocumentFragment();
 
     Logic.identities().forEach(identity => {
+      const hasTabs = (identity.hasHiddenTabs || identity.hasOpenTabs);
+      const arrowClass = hasTabs ? "show-tabs-img" : "no-tabs-img";
       const tr = document.createElement("tr");
       fragment.appendChild(tr);
       tr.classList.add("container-panel-row", "clickable");
@@ -233,7 +235,7 @@ Logic.registerPanel(P_CONTAINERS_LIST, {
           </div>
         </td>
         <td class="open-newtab">${identity.name}</td>
-        <td class="show-tabs"><img src="/img/container-arrow.svg" class="show-tabs show-tabs-img" /></td>`;
+        <td class="show-tabs"><img src="/img/container-arrow.svg" class="show-tabs ${arrowClass}" /></td>`;
 
       tr.addEventListener("click", e => {
         if (e.target.matches(".open-newtab")) {
@@ -250,7 +252,7 @@ Logic.registerPanel(P_CONTAINERS_LIST, {
           }).catch(() => {
             window.close();
           });
-        } else if (e.target.matches(".show-tabs")) {
+        } else if (hasTabs && e.target.matches(".show-tabs")) {
           Logic.showPanel(P_CONTAINER_INFO, identity);
         }
       });