rowan/multi-account-containers
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add Logic.getPanelElementByKey(key), refactor code in Logic.showPanel(panel)

Browse source
This commit is contained in:
dnahol 2019-11-02 02:37:41 -07:00
parent d76c9bf59f
commit 869883ec85
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/js/popup.js
View file

@ -281,7 +281,7 @@ const Logic = {
await this._panels[panel].prepare(); await this._panels[panel].prepare();
Object.keys(this._panels).forEach((panelKey) => { Object.keys(this._panels).forEach((panelKey) => {
const panelItem = this._panels[panelKey]; const panelItem = this._panels[panelKey];
const panelElement = document.querySelector(this.getPanelSelector(panelItem)); const panelElement = this.getPanelElementByKey(panelKey);
if (!panelElement.classList.contains("hide")) { if (!panelElement.classList.contains("hide")) {
panelElement.classList.add("hide"); panelElement.classList.add("hide");
if ("unregister" in panelItem) { if ("unregister" in panelItem) {
@ -289,7 +289,7 @@ const Logic = {
} }
} }
}); });
const panelEl = document.querySelector(this.getPanelSelector(this._panels[panel])); const panelEl = this.getCurrentPanelElement();
panelEl.classList.remove("hide"); panelEl.classList.remove("hide");
const focusEl = panelEl.querySelector(".firstTabindex"); const focusEl = panelEl.querySelector(".firstTabindex");
@ -393,6 +393,11 @@ const Logic = {
const panelItem = this._panels[this._currentPanel]; const panelItem = this._panels[this._currentPanel];
return document.querySelector(this.getPanelSelector(panelItem)); return document.querySelector(this.getPanelSelector(panelItem));
}, },
getPanelElementByKey(panelKey) {
const panelItem = this._panels[panelKey];
return document.querySelector(this.getPanelSelector(panelItem));
}
}; };
// P_ONBOARDING_1: First page for Onboarding. // P_ONBOARDING_1: First page for Onboarding.