From 7f7f221a79acbe731e232e9fdfcb1962e9d3e56c Mon Sep 17 00:00:00 2001 From: shivangikakkar Date: Fri, 21 Sep 2018 14:00:20 +0530 Subject: [PATCH 1/3] fix-#1028 resolves focus name field on opening new container sub-panel --- src/js/popup.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/js/popup.js b/src/js/popup.js index a9e3d26..419377e 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -1001,6 +1001,12 @@ Logic.registerPanel(P_CONTAINER_EDIT, { document.querySelector("#edit-container-panel-name-input").value = identity.name || ""; document.querySelector("#edit-container-panel-usercontext-input").value = userContextId || NEW_CONTAINER_ID; + const containerName = document.querySelector("#edit-container-panel-name-input"); + setTimeout(function() + { + containerName.focus(); + containerName.select(); + }, 0); [...document.querySelectorAll("[name='container-color']")].forEach(colorInput => { colorInput.checked = colorInput.value === identity.color; }); @@ -1015,7 +1021,6 @@ Logic.registerPanel(P_CONTAINER_EDIT, { // P_CONTAINER_DELETE: Delete a container. // ---------------------------------------------------------------------------- - Logic.registerPanel(P_CONTAINER_DELETE, { panelSelector: "#delete-container-panel", From e1c1ac4bd9a7a1394153e3e8866c273acce778ed Mon Sep 17 00:00:00 2001 From: shivangikakkar Date: Fri, 21 Sep 2018 14:31:54 +0530 Subject: [PATCH 2/3] adds back the unnecessarily removed new line --- src/js/popup.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/js/popup.js b/src/js/popup.js index 419377e..0226ddd 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -1021,6 +1021,7 @@ Logic.registerPanel(P_CONTAINER_EDIT, { // P_CONTAINER_DELETE: Delete a container. // ---------------------------------------------------------------------------- + Logic.registerPanel(P_CONTAINER_DELETE, { panelSelector: "#delete-container-panel", From aada0419eb2fb75f5d7856e3787843f7e35ea845 Mon Sep 17 00:00:00 2001 From: shivangikakkar Date: Sun, 30 Sep 2018 18:17:01 +0530 Subject: [PATCH 3/3] removing event loop and using requestAnimationFrame --- src/js/popup.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/js/popup.js b/src/js/popup.js index 0226ddd..c3503b6 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -1002,11 +1002,10 @@ Logic.registerPanel(P_CONTAINER_EDIT, { document.querySelector("#edit-container-panel-name-input").value = identity.name || ""; document.querySelector("#edit-container-panel-usercontext-input").value = userContextId || NEW_CONTAINER_ID; const containerName = document.querySelector("#edit-container-panel-name-input"); - setTimeout(function() - { - containerName.focus(); - containerName.select(); - }, 0); + window.requestAnimationFrame(() => { + containerName.select(); + containerName.focus(); + }); [...document.querySelectorAll("[name='container-color']")].forEach(colorInput => { colorInput.checked = colorInput.value === identity.color; });