From 1af8cf82229ef4e5128299e48f91c0eb26949cb9 Mon Sep 17 00:00:00 2001 From: Kendall Werts Date: Thu, 25 Jul 2019 13:38:17 -0500 Subject: [PATCH 1/3] fix for issue #1314 --- src/js/popup.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/js/popup.js b/src/js/popup.js index a672017..34f6054 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -987,7 +987,7 @@ Logic.registerPanel(P_CONTAINER_EDIT, { This is pending a better solution for favicons from web extensions */ const assumedUrl = `https://${site.hostname}`; trElement.innerHTML = escaped` - +
${site.hostname}
@@ -995,6 +995,7 @@ Logic.registerPanel(P_CONTAINER_EDIT, { class="pop-button-image delete-assignment" src="/img/container-delete.svg" />`; + trElement.querySelector("div").appendChild(Utils.createFavIconElement(assumedUrl)); const deleteButton = trElement.querySelector(".delete-assignment"); const that = this; Logic.addEnterHandler(deleteButton, async () => { From 76f7a64cb8121207a08d8e93b4d6d224663bd5bc Mon Sep 17 00:00:00 2001 From: Kendall Werts Date: Fri, 26 Jul 2019 08:50:22 -0500 Subject: [PATCH 2/3] fixed favicon url --- src/js/popup.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/js/popup.js b/src/js/popup.js index 34f6054..8584b18 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -985,7 +985,7 @@ Logic.registerPanel(P_CONTAINER_EDIT, { const trElement = document.createElement("div"); /* As we don't have the full or correct path the best we can assume is the path is HTTPS and then replace with a broken icon later if it doesn't load. This is pending a better solution for favicons from web extensions */ - const assumedUrl = `https://${site.hostname}`; + const assumedUrl = `https://${site.hostname}/favicon.ico`; trElement.innerHTML = escaped`
From 4d42a74e661bffc8dddb7e6bbb1ea89a0108f7f4 Mon Sep 17 00:00:00 2001 From: Kendall Werts Date: Tue, 6 Aug 2019 20:39:46 -0500 Subject: [PATCH 3/3] Added class to empty div as requested --- src/js/popup.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/popup.js b/src/js/popup.js index 8584b18..af38b7b 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -987,7 +987,7 @@ Logic.registerPanel(P_CONTAINER_EDIT, { This is pending a better solution for favicons from web extensions */ const assumedUrl = `https://${site.hostname}/favicon.ico`; trElement.innerHTML = escaped` -
+
${site.hostname}
@@ -995,7 +995,7 @@ Logic.registerPanel(P_CONTAINER_EDIT, { class="pop-button-image delete-assignment" src="/img/container-delete.svg" />`; - trElement.querySelector("div").appendChild(Utils.createFavIconElement(assumedUrl)); + trElement.getElementsByClassName("favicon")[0].appendChild(Utils.createFavIconElement(assumedUrl)); const deleteButton = trElement.querySelector(".delete-assignment"); const that = this; Logic.addEnterHandler(deleteButton, async () => {