Fix (and suppress) eslint errors

This commit is contained in:
stoically 2019-12-06 06:39:02 +01:00
parent 02c344c1e1
commit 9b9c38949e
No known key found for this signature in database
GPG key ID: 3026ED2F90EE0DE9
3 changed files with 30 additions and 28 deletions

View file

@ -82,6 +82,7 @@ const messageHandler = {
if (!extensionInfo.permissions.includes("contextualIdentities")) { if (!extensionInfo.permissions.includes("contextualIdentities")) {
throw new Error("Missing contextualIdentities permission"); throw new Error("Missing contextualIdentities permission");
} }
// eslint-disable-next-line require-atomic-updates
externalExtensionAllowed[sender.id] = true; externalExtensionAllowed[sender.id] = true;
} }
let response; let response;

View file

@ -3,24 +3,24 @@ function requestPermissions() {
const checkbox = document.querySelector("#bookmarksPermissions"); const checkbox = document.querySelector("#bookmarksPermissions");
if (checkbox.checked) { if (checkbox.checked) {
browser.permissions.request({permissions: ["bookmarks"]}). browser.permissions.request({permissions: ["bookmarks"]}).
then((response) => { then((response) => {
if (response) { if (response) {
browser.runtime.sendMessage({ method: "resetBookmarksContext" }); browser.runtime.sendMessage({ method: "resetBookmarksContext" });
} else { } else {
checkbox.checked = false; checkbox.checked = false;
} }
}). }).
catch((err) => { catch((err) => {
return err.message; return err.message;
}); });
} else { } else {
browser.permissions.remove({permissions: ["bookmarks"]}). browser.permissions.remove({permissions: ["bookmarks"]}).
then(() => { then(() => {
browser.runtime.sendMessage({ method: "resetBookmarksContext" }); browser.runtime.sendMessage({ method: "resetBookmarksContext" });
}). }).
catch((err) => { catch((err) => {
return err.message; return err.message;
}); });
} }
} }

View file

@ -259,6 +259,7 @@ const Logic = {
getPanelSelector(panel) { getPanelSelector(panel) {
if (this._onboardingVariation === "securityOnboarding" && if (this._onboardingVariation === "securityOnboarding" &&
// eslint-disable-next-line no-prototype-builtins
panel.hasOwnProperty("securityPanelSelector")) { panel.hasOwnProperty("securityPanelSelector")) {
return panel.securityPanelSelector; return panel.securityPanelSelector;
} else { } else {
@ -570,21 +571,21 @@ Logic.registerPanel(P_CONTAINERS_LIST, {
break; break;
} }
case 39: case 39:
{ {
const showTabs = element.parentNode.querySelector(".show-tabs"); const showTabs = element.parentNode.querySelector(".show-tabs");
if(showTabs) { if(showTabs) {
showTabs.click(); showTabs.click();
}
break;
} }
break;
}
case 37: case 37:
{ {
const hideTabs = document.querySelector(".panel-back-arrow"); const hideTabs = document.querySelector(".panel-back-arrow");
if(hideTabs) { if(hideTabs) {
hideTabs.click(); hideTabs.click();
}
break;
} }
break;
}
default: default:
if ((e.keyCode >= 49 && e.keyCode <= 57) && if ((e.keyCode >= 49 && e.keyCode <= 57) &&
Logic._currentPanel === "containersList") { Logic._currentPanel === "containersList") {