From b0811049b19e7f0fdca8e17753c1086cb3fa8da3 Mon Sep 17 00:00:00 2001 From: Maxx Crawford Date: Tue, 21 Sep 2021 15:15:00 -0500 Subject: [PATCH] Move panel titles to i18n --- src/_locales/en/messages.json | 7 +++++++ src/js/popup.js | 6 +++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/_locales/en/messages.json b/src/_locales/en/messages.json index d303455..ac525f8 100644 --- a/src/_locales/en/messages.json +++ b/src/_locales/en/messages.json @@ -19,9 +19,16 @@ "message": "Always Open This Site in…", "description": "Menu title" }, + "alwaysOpenIn": { + "message": "Always open in…", + "description": "Menu title" + }, "alwaysOpenSiteInContainer": { "message": "Always Open Site in Container" }, + "openANewTabIn": { + "message" : "Open a New Tab in…" + }, "openNewTabInThisContainer": { "message" : "Open New Tab in this Container" }, diff --git a/src/js/popup.js b/src/js/popup.js index 5896195..c739847 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -920,7 +920,7 @@ Logic.registerPanel(OPEN_NEW_CONTAINER_PICKER, { // This method is called when the panel is shown. prepare() { Logic.listenToPickerBackButton(); - document.getElementById("picker-title").textContent = "Open a New Tab in"; + document.getElementById("picker-title").textContent = browser.i18n.getMessage("openANewTabIn"); const fragment = document.createDocumentFragment(); const pickedFunction = function (identity) { try { @@ -1104,7 +1104,7 @@ Logic.registerPanel(REOPEN_IN_CONTAINER_PICKER, { // This method is called when the panel is shown. async prepare() { Logic.listenToPickerBackButton(); - document.getElementById("picker-title").textContent = "Reopen This Site in"; + document.getElementById("picker-title").textContent = browser.i18n.getMessage("reopenThisSiteIn"); const fragment = document.createDocumentFragment(); const currentTab = await Utils.currentTab(); const pickedFunction = function (identity) { @@ -1197,7 +1197,7 @@ Logic.registerPanel(ALWAYS_OPEN_IN_PICKER, { // This method is called when the panel is shown. prepare() { Logic.listenToPickerBackButton(); - document.getElementById("picker-title").textContent = "Always Open in"; + document.getElementById("picker-title").textContent = browser.i18n.getMessage("alwaysOpenIn"); const fragment = document.createDocumentFragment(); document.getElementById("new-container-div").innerHTML = "";