From 5bbf902b4762adefc77a51811b9d8ab19051fadf Mon Sep 17 00:00:00 2001 From: Kendall Werts Date: Wed, 26 Feb 2020 17:02:01 -0600 Subject: [PATCH] fix for #1656, #1643, and #1637 removes enter key listener in favor of focus highlighting to notify user that there is keyboard navigation available for the onboarding panels. (enter key listener was added as keyboard navication for onboarding panels). bumped version --- package.json | 3 ++- src/css/popup.css | 5 +++++ src/js/popup.js | 8 -------- src/manifest.json | 2 +- src/popup.html | 24 ++++++++++++------------ 5 files changed, 20 insertions(+), 22 deletions(-) diff --git a/package.json b/package.json index ded707c..1bf6531 100644 --- a/package.json +++ b/package.json @@ -2,7 +2,7 @@ "name": "testpilot-containers", "title": "Multi-Account Containers", "description": "Containers helps you keep all the parts of your online life contained in different tabs. Custom labels and color-coded tabs help keep different activities — like online shopping, travel planning, or checking work email — separate.", - "version": "6.2.1", + "version": "6.2.2", "author": "Andrea Marchesini, Luke Crouch and Jonathan Kingston", "bugs": { "url": "https://github.com/mozilla/multi-account-containers/issues" @@ -37,6 +37,7 @@ }, "scripts": { "build": "npm test && cd src && web-ext build --overwrite-dest", + "webext": "web-ext run -s src/", "lint": "npm-run-all lint:*", "lint:addon": "addons-linter src --self-hosted", "lint:css": "stylelint src/css/*.css", diff --git a/src/css/popup.css b/src/css/popup.css index 2ffbce5..3ce65aa 100644 --- a/src/css/popup.css +++ b/src/css/popup.css @@ -390,6 +390,11 @@ table { background-color: #0675d3; } +.onboarding-button:focus, +.half-onboarding-button:focus { + box-shadow: 0 0 0 1px #0a84ff inset, 0 0 0 1px #0a84ff, 0 0 0 4px rgba(10, 132, 255, 0.3); +} + /* Pop buttons are the square shaped buttons used to manage things like container crud */ .pop-button { diff --git a/src/js/popup.js b/src/js/popup.js index b93981d..92f54b4 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -633,14 +633,6 @@ Logic.registerPanel(P_CONTAINERS_LIST, { case 38: previous(); break; - case 13: { - const panel = Logic.getCurrentPanelElement(); - const button = panel.getElementsByTagName("A")[0]; - if(button) { - button.click(); - } - break; - } case 39: { const showTabs = element.parentNode.querySelector(".show-tabs"); diff --git a/src/manifest.json b/src/manifest.json index e88af90..4c1480f 100644 --- a/src/manifest.json +++ b/src/manifest.json @@ -1,7 +1,7 @@ { "manifest_version": 2, "name": "Firefox Multi-Account Containers", - "version": "6.2.1", + "version": "6.2.2", "incognito": "not_allowed", "description": "Multi-Account Containers helps you keep all the parts of your online life contained in different tabs. Custom labels and color-coded tabs help keep different activities — like online shopping, travel planning, or checking work email — separate.", "icons": { diff --git a/src/popup.html b/src/popup.html index 1497212..813a02d 100644 --- a/src/popup.html +++ b/src/popup.html @@ -13,7 +13,7 @@

Use containers to organize tasks, manage accounts, and keep your focus where you want it.

- Get Started + Get Started
@@ -22,49 +22,49 @@

Use containers to organize tasks, manage accounts, and store sensitive data.

- Get Started + Get Started
How Containers Work

Put containers to work for you.

Features like color-coding and separate container tabs help you find things easily, focus your attention, and minimize distractions.

- Next + Next
How Containers Work

Put containers to work for you.

Color-coding helps you categorize your online life, find things easily, and minimize distractions.

- Next + Next
How Containers Work

A place for everything, and everything in its place.

Start with the containers we've created, or create your own.

- Next + Next
How Containers Work

Set boundaries for your browsing.

Cookies are stored within a container, so you can segment sensitive data and browsing history to stay organized and to limit the impact of online trackers.

- Next + Next
How to assign sites to containers

Always open sites in the containers you want.

Right-click inside a container tab to assign the site to always open in the container.

- Next + Next
Long-press the New Tab button to create a new container tab.

Container tabs when you need them.

Long-press the New Tab button to create a new container tab.

- Next + Next
@@ -72,8 +72,8 @@

Syncing Containers is now Available!

Turn on Sync to share container and site assignments with any computer connected to your Firefox Account.

- Not Now - Start Syncing + Not Now + Start Syncing
@@ -82,8 +82,8 @@

Firefox Account is required to sync.

Click Sign In to confirm that your Firefox Account is active.

- Not Now - Sign In + Not Now + Sign In