rowan/multi-account-containers
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix #1053.

Browse source 
Create the new window with the default tab rather than an existing tab,
then pin the default tab. This allows any pinned tabs to be moved to the
new window because they're not allowed to be moved after a un-pinned
tab. The default tab is automatically closed later in `moveTabsToWindow`
because it's not a part of the container.
This commit is contained in:
Eric Lathrop 2017-12-22 11:45:52 -05:00
parent bea201a389
commit d7a2b43b07
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/js/background/backgroundLogic.js
View file

@ -131,9 +131,13 @@ const backgroundLogic = {
let newWindowObj; let newWindowObj;
let hiddenDefaultTabToClose; let hiddenDefaultTabToClose;
if (list.length) { if (list.length) {
newWindowObj = await browser.windows.create({ newWindowObj = await browser.windows.create();
tabId: list.shift().id
}); // Pin the default tab in the new window so existing pinned tabs can be moved after it.
// From the docs (https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/move):
// Note that you can't move pinned tabs to a position after any unpinned tabs in a window, or move any unpinned tabs to a position before any pinned tabs.
await browser.tabs.update(newWindowObj.tabs[0].id, { pinned: true });
browser.tabs.move(list.map((tab) => tab.id), { browser.tabs.move(list.map((tab) => tab.id), {
windowId: newWindowObj.id, windowId: newWindowObj.id,
index: -1 index: -1