review changes

This commit is contained in:
shivangikakkar 2018-09-20 23:40:22 +05:30
parent dd57158ab5
commit e57c556427

View file

@ -212,7 +212,7 @@ const Logic = {
return false; return false;
}, },
async noOfTabs() { async numTabs() {
const activeTabs = await browser.tabs.query({windowId: browser.windows.WINDOW_ID_CURRENT}); const activeTabs = await browser.tabs.query({windowId: browser.windows.WINDOW_ID_CURRENT});
return activeTabs.length; return activeTabs.length;
}, },
@ -722,8 +722,9 @@ Logic.registerPanel(P_CONTAINER_INFO, {
moveTabsEl.parentNode.insertBefore(fragment, moveTabsEl.nextSibling); moveTabsEl.parentNode.insertBefore(fragment, moveTabsEl.nextSibling);
} else { } else {
Logic.noOfTabs().then(result => { try {
if (result === 1) { const numTabs = await Logic.numTabs();
if (numTabs === 1) {
moveTabsEl.classList.remove("clickable"); moveTabsEl.classList.remove("clickable");
} else { } else {
Logic.addEnterHandler(moveTabsEl, async function () { Logic.addEnterHandler(moveTabsEl, async function () {
@ -735,9 +736,9 @@ Logic.registerPanel(P_CONTAINER_INFO, {
window.close(); window.close();
}); });
} }
}).catch(error => { } catch (e) {
throw new Error(error); throw new Error("Could not get the number of active tabs.");
}); }
} }
} catch (e) { } catch (e) {
throw new Error("Could not check for incompatible add-ons."); throw new Error("Could not check for incompatible add-ons.");