From 2cddbefb63c46ecffd4795227795443d61a79483 Mon Sep 17 00:00:00 2001 From: dnahol Date: Fri, 18 Oct 2019 13:47:54 -0700 Subject: [PATCH 1/2] added keyboard nav to onboarding popups --- src/js/popup.js | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/js/popup.js b/src/js/popup.js index e5b4dbf..6e9f3bb 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -382,6 +382,11 @@ const Logic = { } } }, + + getCurrentPanel() { + const panelItem = this._panels[this._currentPanel]; + return document.querySelector(this.getPanelSelector(panelItem)); + }, }; // P_ONBOARDING_1: First page for Onboarding. @@ -550,6 +555,14 @@ Logic.registerPanel(P_CONTAINERS_LIST, { case 38: previous(); break; + case 13: { + const panel = Logic.getCurrentPanel(); + const button = panel.getElementsByTagName("A")[0]; + if(button) { + button.click(); + } + break; + } default: if ((e.keyCode >= 49 && e.keyCode <= 57) && Logic._currentPanel === "containersList") { @@ -1154,4 +1167,4 @@ window.addEventListener("resize", function () { root.style.setProperty("--overflow-size", difference + "px"); root.style.setProperty("--icon-fit", "12"); } -}); \ No newline at end of file +}); From 29a0277398331a2ac05568e827315c8f7fabfaf9 Mon Sep 17 00:00:00 2001 From: dnahol Date: Thu, 24 Oct 2019 10:17:32 -0700 Subject: [PATCH 2/2] change getCurrentPanel to getCurrentPanelElement --- src/js/popup.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/js/popup.js b/src/js/popup.js index 6e9f3bb..ffee10a 100644 --- a/src/js/popup.js +++ b/src/js/popup.js @@ -383,7 +383,7 @@ const Logic = { } }, - getCurrentPanel() { + getCurrentPanelElement() { const panelItem = this._panels[this._currentPanel]; return document.querySelector(this.getPanelSelector(panelItem)); }, @@ -556,7 +556,7 @@ Logic.registerPanel(P_CONTAINERS_LIST, { previous(); break; case 13: { - const panel = Logic.getCurrentPanel(); + const panel = Logic.getCurrentPanelElement(); const button = panel.getElementsByTagName("A")[0]; if(button) { button.click();