rowan/multi-account-containers
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #1055 from ericlathrop/fix-moving-pinned-tabs-to-new-window

Browse source 
Fix #1053.
This commit is contained in:
luke crouch 2018-01-29 11:02:14 -06:00 • committed by GitHub
commit f17ff7168f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/js/background/backgroundLogic.js
View file

@ -131,9 +131,13 @@ const backgroundLogic = {
let newWindowObj; let newWindowObj;
let hiddenDefaultTabToClose; let hiddenDefaultTabToClose;
if (list.length) { if (list.length) {
newWindowObj = await browser.windows.create({ newWindowObj = await browser.windows.create();
tabId: list.shift().id
}); // Pin the default tab in the new window so existing pinned tabs can be moved after it.
// From the docs (https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/tabs/move):
// Note that you can't move pinned tabs to a position after any unpinned tabs in a window, or move any unpinned tabs to a position before any pinned tabs.
await browser.tabs.update(newWindowObj.tabs[0].id, { pinned: true });
browser.tabs.move(list.map((tab) => tab.id), { browser.tabs.move(list.map((tab) => tab.id), {
windowId: newWindowObj.id, windowId: newWindowObj.id,
index: -1 index: -1