Commit graph

34 commits

Author SHA1 Message Date
André Schröder
4d76c937fe fix typos 2021-01-11 20:11:06 +01:00
André Schröder
649110ed45 fix concerns 2021-01-11 20:09:11 +01:00
Andre Schröder
a1d01f8ff2 Fix development instructions in README
web-ext will not work when following the instructions without having
this diff applied:

```
$ ./node_modules/web-ext/bin/web-ext run -s src/
(node:41062) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)
(node:41062) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'find' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'head' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'set' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'test' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'to' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency
(node:41062) Warning: Accessing non-existent property 'which' of module exports inside circular dependency
Applying config file: ./package.json
Running web extension from /home/andre/Git/multi-account-containers/src
Use --verbose or open Tools > Web Developer > Browser Console to see logging

WebExtError: Temporary add-on installation is not supported in this version of Firefox (you need Firefox 49 or higher). For older Firefox versions, use --pre-install
    at FirefoxDesktopExtensionRunner._callee6$ (/home/andre/Git/multi-account-containers/node_modules/web-ext/dist/webpack:/src/extension-runners/firefox-desktop.js:273:19)
    at tryCatch (/home/andre/Git/multi-account-containers/node_modules/web-ext/node_modules/regenerator-runtime/runtime.js:62:40)
    at Generator.invoke [as _invoke] (/home/andre/Git/multi-account-containers/node_modules/web-ext/node_modules/regenerator-runtime/runtime.js:296:22)
    at Generator.prototype.<computed> [as throw] (/home/andre/Git/multi-account-containers/node_modules/web-ext/node_modules/regenerator-runtime/runtime.js:114:21)
    at step (/home/andre/Git/multi-account-containers/node_modules/web-ext/dist/webpack:/node_modules/babel-runtime/helpers/asyncToGenerator.js:17:1)
    at /home/andre/Git/multi-account-containers/node_modules/web-ext/dist/webpack:/node_modules/babel-runtime/helpers/asyncToGenerator.js:30:1
    at processTicksAndRejections (node:internal/process/task_queues:93:5)
```

web-ext will work when following the instructions with having this diff
applied:

```
$ web-ext run -s src/
Applying config file: ./package.json
Running web extension from /home/andre/Git/multi-account-containers/src
Use --verbose or open Tools > Web Developer > Browser Console to see logging
Installed /home/andre/Git/multi-account-containers/src as a temporary add-on
The extension will reload if any source file changes
Press R to reload (and Ctrl-C to quit)
```

I copied the wording from
2184fee75a/README.md

I guess the underlying problem is that the web-ext version specified in
the package.json is very outdated. By installing the web-ext tool via
the provided instructions it fixes the problem.

Furthermore, the `webextensions-examples` repo doesn't specify web-ext
in their package.json which means that installing web-ext via the
provided instructions seems to be the preferred way. (So maybe web-ext
should be removed from the package.json entirely?)

Fixes #1926
2020-12-23 04:13:16 +01:00
Kendall Werts
beb027f1a1 updated readme 2020-02-10 12:38:57 -06:00
dnahol
645fb6832c fix 'License' typo 2019-11-02 22:49:31 -07:00
Kendall Werts
397a3e4970 updated test info 2019-10-11 10:38:33 -05:00
Jonathan Kingston
e0156388e8
Adding an s:// 2018-02-09 18:37:29 +00:00
Tiago Botelho
1e16e203dc Fixes code markdown wrapping under Development in the README section 2018-01-08 20:37:35 +00:00
groovecoder
bea201a389 update README & package.json to match web-ext flow 2017-12-05 19:06:13 +00:00
Jonathan Kingston
d944116e3e Move to a Web Extension only. Fixes #1005 2017-12-05 19:06:13 +00:00
groovecoder
df8471a4dd bump version to 4.1.0 2017-11-16 09:47:18 -06:00
groovecoder
31298146f3 when user reaches container tab count, show achievement panel 2017-11-16 15:30:02 +00:00
groovecoder
8166a37722 add steps for signing, AMO, and GitHub to README 2017-09-29 13:15:16 -05:00
Jonathan Kingston
88e6dc7a05 Add strict min version and extension id and bump version to 4.0.2. Fixes #692. Fixes #852 2017-09-23 23:36:24 +01:00
Jonathan Kingston
e84e482130 Minor README edit 2017-09-15 00:17:05 +01:00
Jonathan Kingston
3ec81e3d1f Add launch notice in README 2017-09-14 23:15:01 +01:00
groovecoder
80661d68f2 fix #809: use "Containers" for name for context menu 2017-09-13 16:16:43 -05:00
Jonathan Kingston
3aa311a3c1 Name change. Fixes #763 2017-09-01 15:16:56 -07:00
Jonathan Kingston
f526caca50 Add web extension specific advice on building. Fixes #751 2017-08-30 11:12:55 -07:00
Jonathan Kingston
57a31f7f97 Remove legacy telemetry code as non functional now 2017-08-15 19:30:57 +01:00
Jonathan Kingston
30c55e093c Add a code of conduct and contributing file. 2017-06-23 14:22:26 +01:00
groovecoder
78ef2e8304 update README for shield per @kjozwiak 2017-06-14 23:10:50 +01:00
Jonathan Kingston
094a0e2391 Update README.md to bump Firefox version number 2017-06-04 22:22:42 +01:00
Jonathan Kingston
08ba094748 add npm run build-shield command 2017-05-19 14:31:58 -05:00
Jonathan Kingston
099d07bf1f Update shield install path 2017-05-17 12:37:24 -05:00
groovecoder
84dd73bff5 update README with shield run instructions 2017-05-17 12:37:24 -05:00
TJ Walker
0220135880 Update README.md
Correct indication of feature availability.
2017-03-08 20:39:00 -08:00
groovecoder
49c643b72c add xpi instructions to README 2017-02-21 15:27:26 -06:00
baku
64498da783 README updated for FF51 2017-01-09 12:04:27 +01:00
Jonathan Kingston
a1f08175a2 Adding in explanation for beta building (#36) 2017-01-06 16:02:17 +00:00
groovecoder
976b2f796d update README to be current 2017-01-05 16:40:25 -06:00
groovecoder
5b753dc146 initial commit 2016-12-15 16:27:05 -06:00
John Gruen
9dc1dc9aaf add acceptance 2016-12-15 12:28:55 -05:00
Wil Clouser
720f139b16 Initial commit 2016-12-01 11:52:55 -08:00