chore: build a shared library

This ensures that the menu is rendered with the correct scale.

Fixes #14

README.md

@@ -15,7 +15,7 @@ Dependencies:
 - scdoc (optional)
 
 ```
-$ meson build
+$ meson setup build
 $ ninja -C build
 # ninja -C build install
 ```

menu.c

@@ -1,4 +1,5 @@
 #define _POSIX_C_SOURCE 200809L
+#include <assert.h>
 #include <ctype.h>
 #include <poll.h>
 #include <stdbool.h>
@@ -33,6 +34,8 @@ struct menu *menu_create(menu_callback callback) {
 	menu->selectionbg = 0x005577ff;
 	menu->selectionfg = 0xeeeeeeff;
 	menu->callback = callback;
+	menu->test_surface = cairo_image_surface_create(CAIRO_FORMAT_ARGB32, 1, 1);
+	menu->test_cairo = cairo_create(menu->test_surface);
 	return menu;
 }
 
@@ -45,24 +48,20 @@ static void free_pages(struct menu *menu) {
 	}
 }
 
-static void free_item(struct item *item) {
-	free(item->text);
-	free(item);
-}
-
 static void free_items(struct menu *menu) {
-	struct item *next = menu->items;
+	for (size_t i = 0; i < menu->item_count; i++) {
-	while (next) {
+		struct item *item = &menu->items[i];
-		struct item *item = next;
+		free(item->text);
-		next = item->next;
-		free_item(item);
 	}
+	free(menu->items);
 }
 
 // Destroys the menu, freeing memory associated with it.
 void menu_destroy(struct menu *menu) {
 	free_pages(menu);
 	free_items(menu);
+	cairo_destroy(menu->test_cairo);
+	cairo_surface_destroy(menu->test_surface);
 	free(menu);
 }
 
@@ -167,34 +166,44 @@ void menu_getopts(struct menu *menu, int argc, char *argv[]) {
 }
 
 // Add an item to the menu.
-void menu_add_item(struct menu *menu, char *text, bool sort) {
+void menu_add_item(struct menu *menu, char *text) {
-	struct item *new = calloc(1, sizeof(struct item));
+	if ((menu->item_count & (menu->item_count - 1)) == 0) {
-	if (!new) {
+		size_t alloc_size = menu->item_count ? 2 * menu->item_count : 1;
-		return;
+		void *new_array = realloc(menu->items, sizeof(struct item) * alloc_size);
+		if (!new_array) {
+			fprintf(stderr, "could not realloc %zu bytes", sizeof(struct item) * alloc_size);
+			exit(EXIT_FAILURE);
+		}
+		menu->items = new_array;
 	}
+
+	struct item *new = &menu->items[menu->item_count];
 	new->text = text;
 
-	if (sort) {
+	menu->item_count++;
-		for (struct item **item = &menu->items; *item; item = &(*item)->next) {
+}
-			int result = strcmp(new->text, (*item)->text);
+
-			if (result == 0) {
+static int compare_items(const void *a, const void *b) {
-				free_item(new);
+	const struct item *item_a = a;
-				return;
+	const struct item *item_b = b;
-			}
+	return strcmp(item_a->text, item_b->text);
-			if (result < 0) {
+}
-				new->next = *item;
+
-				*item = new;
+void menu_sort_and_deduplicate(struct menu *menu) {
-				return;
+	size_t j = 1;
-			}
+	size_t i;
+
+	qsort(menu->items, menu->item_count, sizeof(*menu->items), compare_items);
+
+	for (i = 1; i < menu->item_count; i++) {
+		if (strcmp(menu->items[i].text, menu->items[j - 1].text) == 0) {
+			free(menu->items[i].text);
+		} else {
+			menu->items[j] = menu->items[i];
+			j++;
 		}
 	}
-
+	menu->item_count = j;
-	if (menu->lastitem) {
-		menu->lastitem->next = new;
-	} else {
-		menu->items = new;
-	}
-	menu->lastitem = new;
 }
 
 static void append_page(struct page *page, struct page **first, struct page **last) {
@@ -291,6 +300,7 @@ static void match_items(struct menu *menu) {
 	char buf[sizeof menu->input], *tok;
 	char **tokv = NULL;
 	int i, tokc = 0;
+	size_t k;
 	size_t tok_len;
 	menu->matches = NULL;
 	menu->matches_end = NULL;
@@ -314,8 +324,8 @@ static void match_items(struct menu *menu) {
 	}
 	tok_len = tokc ? strlen(tokv[0]) : 0;
 
-	struct item *item;
+	for (k = 0; k < menu->item_count; k++) {
-	for (item = menu->items; item; item = item->next) {
+		struct item *item = &menu->items[k];
 		for (i = 0; i < tokc; i++) {
 			if (!fstrstr(menu, item->text, tokv[i])) {
 				/* token does not match */
@@ -368,7 +378,6 @@ static void match_items(struct menu *menu) {
 
 // Render menu items.
 void menu_render_items(struct menu *menu) {
-	render_menu(menu);
 	calc_widths(menu);
 	match_items(menu);
 	render_menu(menu);

menu.h

@@ -1,6 +1,7 @@
 #ifndef WMENU_MENU_H
 #define WMENU_MENU_H
 
+#include <cairo/cairo.h>
 #include <stdbool.h>
 #include <sys/types.h>
 #include <xkbcommon/xkbcommon.h>
@@ -13,7 +14,6 @@ typedef void (*menu_callback)(struct menu *menu, char *text, bool exit);
 struct item {
 	char *text;
 	int width;
-	struct item *next;       // traverses all items
 	struct item *prev_match; // previous matching item
 	struct item *next_match; // next matching item
 	struct page *page;       // the page holding this item
@@ -52,6 +52,10 @@ struct menu {
 
 	struct wl_context *context;
 
+	// 1x1 surface used estimate text sizes with pango
+	cairo_surface_t *test_surface;
+	cairo_t *test_cairo;
+
 	int width;
 	int height;
 	int line_height;
@@ -64,8 +68,8 @@ struct menu {
 	char input[BUFSIZ];
 	size_t cursor;
 
-	struct item *items;       // list of all items
+	struct item *items;       // array of all items
-	struct item *lastitem;    // last item in the list
+	size_t item_count;
 	struct item *matches;     // list of matching items
 	struct item *matches_end; // last matching item
 	struct item *sel;         // selected item
@@ -79,7 +83,8 @@ struct menu {
 struct menu *menu_create(menu_callback callback);
 void menu_destroy(struct menu *menu);
 void menu_getopts(struct menu *menu, int argc, char *argv[]);
-void menu_add_item(struct menu *menu, char *text, bool sort);
+void menu_add_item(struct menu *menu, char *text);
+void menu_sort_and_deduplicate(struct menu *menu);
 void menu_render_items(struct menu *menu);
 void menu_paste(struct menu *menu, const char *text, ssize_t len);
 void menu_keypress(struct menu *menu, enum wl_keyboard_key_state key_state,

meson.build

@@ -33,6 +33,28 @@ rt = cc.find_library('rt')
 subdir('protocols')
 subdir('docs')
 
+shared_library(
+	'wmenu',
+	files(
+		'menu.c',
+		'pango.c',
+		'pool-buffer.c',
+		'render.c',
+		'wayland.c',
+		'wmenu.c',
+	),
+	dependencies: [
+		cairo,
+		client_protos,
+		pango,
+		pangocairo,
+		rt,
+		wayland_client,
+		wayland_protos,
+		xkbcommon,
+	],
+)
+
 executable(
 	'wmenu',
 	files(

render.c

@@ -13,8 +13,13 @@
 // Calculate text widths.
 void calc_widths(struct menu *menu) {
 	struct wl_context *context = menu->context;
-	struct pool_buffer *current = context_get_current_buffer(context);
+	int scale = context_get_scale(context);
-	cairo_t *cairo = current->cairo;
+	cairo_surface_set_device_scale(menu->test_surface, scale, scale);
+	cairo_set_antialias(menu->test_cairo, CAIRO_ANTIALIAS_BEST);
+	cairo_font_options_t *fo = cairo_font_options_create();
+	cairo_set_font_options(menu->test_cairo, fo);
+	cairo_font_options_destroy(fo);
+	cairo_t *cairo = menu->test_cairo;
 
 	// Calculate prompt width
 	if (menu->prompt) {
@@ -28,7 +33,8 @@ void calc_widths(struct menu *menu) {
 	menu->right_arrow = text_width(cairo, menu->font, ">") + 2 * menu->padding;
 
 	// Calculate item widths and input area width
-	for (struct item *item = menu->items; item; item = item->next) {
+	for (size_t i = 0; i < menu->item_count; i++) {
+		struct item *item = &menu->items[i];
 		item->width = text_width(cairo, menu->font, item->text);
 		if (item->width > menu->inputw) {
 			menu->inputw = item->width;
@@ -183,41 +189,22 @@ static void render_to_cairo(struct menu *menu, cairo_t *cairo) {
 void render_menu(struct menu *menu) {
 	struct wl_context *context = menu->context;
 
-	cairo_surface_t *recorder = cairo_recording_surface_create(
-			CAIRO_CONTENT_COLOR_ALPHA, NULL);
-	cairo_t *cairo = cairo_create(recorder);
-	cairo_set_antialias(cairo, CAIRO_ANTIALIAS_BEST);
-	cairo_font_options_t *fo = cairo_font_options_create();
-	cairo_set_font_options(cairo, fo);
-	cairo_font_options_destroy(fo);
-	cairo_save(cairo);
-	cairo_set_operator(cairo, CAIRO_OPERATOR_CLEAR);
-	cairo_paint(cairo);
-	cairo_restore(cairo);
-
-	render_to_cairo(menu, cairo);
-
 	int scale = context_get_scale(context);
 	struct pool_buffer *buffer = context_get_next_buffer(context, scale);
 	if (!buffer) {
-		goto cleanup;
+		return;
 	}
 
 	cairo_t *shm = buffer->cairo;
-	cairo_save(shm);
+	cairo_set_antialias(shm, CAIRO_ANTIALIAS_BEST);
-	cairo_set_operator(shm, CAIRO_OPERATOR_CLEAR);
+	cairo_font_options_t *fo = cairo_font_options_create();
-	cairo_paint(shm);
+	cairo_set_font_options(shm, fo);
-	cairo_restore(shm);
+	cairo_font_options_destroy(fo);
-	cairo_set_source_surface(shm, recorder, 0, 0);
+	render_to_cairo(menu, shm);
-	cairo_paint(shm);
 
 	struct wl_surface *surface = context_get_surface(context);
 	wl_surface_set_buffer_scale(surface, scale);
 	wl_surface_attach(surface, buffer->buffer, 0, 0);
 	wl_surface_damage(surface, 0, 0, menu->width, menu->height);
 	wl_surface_commit(surface);
-
-cleanup:
-	cairo_destroy(cairo);
-	cairo_surface_destroy(recorder);
 }

wayland.c

@@ -208,6 +208,7 @@ static void noop() {
 static void surface_enter(void *data, struct wl_surface *surface, struct wl_output *wl_output) {
 	struct wl_context *context = data;
 	context->output = wl_output_get_user_data(wl_output);
+	menu_render_items(context->menu);
 }
 
 static const struct wl_surface_listener surface_listener = {
@@ -439,7 +440,7 @@ int menu_run(struct menu *menu) {
 		context->layer_shell,
 		context->surface,
 		context->output ? context->output->output : NULL,
-		ZWLR_LAYER_SHELL_V1_LAYER_TOP,
+		ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY,
 		"menu"
 	);
 	assert(layer_surface != NULL);

wmenu-run.c

@@ -20,10 +20,11 @@ static void read_items(struct menu *menu) {
 			if (ent->d_name[0] == '.') {
 				continue;
 			}
-			menu_add_item(menu, strdup(ent->d_name), true);
+			menu_add_item(menu, strdup(ent->d_name));
 		}
 		closedir(dir);
 	}
+	menu_sort_and_deduplicate(menu);
 	free(path);
 }
 

wmenu.c

@@ -13,7 +13,7 @@ static void read_items(struct menu *menu) {
 		if (p) {
 			*p = '\0';
 		}
-		menu_add_item(menu, strdup(buf), false);
+		menu_add_item(menu, strdup(buf));
 	}
 }